Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading curtsies version to include changes from PR 111 to fix typing bug #862

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

kelseylb
Copy link

bpython/curtsies#111 fixed an issue that causes a crash in mypy, but bpython isn't guaranteed to use a version of curtsies that includes this fix. this diff upgrades the bpython dependency on curtsies to 0.3.3, the latest release.

i couldn't find a contributing.md or similar to show how to build and test the diff, or with any other guidelines for contributors, so if there are additional steps i should take before this is shippable, please let me know!

@sebastinas sebastinas merged commit ff2acf1 into bpython:master Nov 13, 2020
@kelseylb
Copy link
Author

thanks for the merge, @sebastinas! what should I expect in terms of process to see this released?

@sebastinas
Copy link
Contributor

Unless some major issue affecting 0.20.1 pops up, we haven't planned any release until the beginning of 2021. But if we need to do a 0.20.2, it will be included. Otherwise it will be part of 0.21.

@kelseylb
Copy link
Author

when do you expect to release 0.21? this bug is blocking our adoption of mypy, and we need to either fix it or migrate off of bpython to unblock that effort.

@sebastinas
Copy link
Contributor

I'm not sure I'm following. The current requirments does not prevent upgrading curtsies to 0.3.3. @supakeen Any opinion on that?

@supakeen
Copy link
Member

supakeen commented Nov 14, 2020

I currently get curtsies 0.3.4 on a fresh install:

€ python3.8 -m venv venv
...
€ venv/bin/pip install bpython
...
€ venv/bin/pip freeze | grep curtsies
curtsies==0.3.4

Can you tell me how you're receiving the older version of curtsies, if there's a way to get that then a 0.20.2 is warranted.

As a side-note, it'd be a great idea to add a CONTRIBUTING.md 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants