Skip to content

Commit

Permalink
update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bquast committed Apr 23, 2020
1 parent 71e539b commit 36fc1e2
Showing 1 changed file with 16 additions and 17 deletions.
33 changes: 16 additions & 17 deletions cran-comments.md
@@ -1,28 +1,27 @@
## Test environments

- Local Arch Linux R 3.6.2
- Ubuntu (Travic-CI) R-3.6.2
- Win-Builder devel
- Local Arch Linux R 3.6.3
- Ubuntu (Travic-CI) R-3.6.3
- Win-Builder devel and release

## R CMD check results
There were no ERRORs or WARNINGs.

N checking R code for possible problems (3s)
decomp_gadget : server: no visible binding for '<<-' assignment to
‘.decomposed’

Found the following assignments to the global environment:
File ‘decompr/R/decomp_gadget.R’:
assign(paste(outputobj), .decomposed, envir = .GlobalEnv)

Found the following calls to data() loading into the global environment:
File ‘decompr/R/decomp_gadget.R’:
data(list = paste("wiod", input$wiodselect, sep = ""))
data(leather, package = "decompr")
See section ‘Good practice’ in ‘?data’.
* checking R code for possible problems ... [7s] NOTE
decomp_gadget : server: no visible binding for '<<-' assignment to
'.decomposed'

Found the following assignments to the global environment:
File 'decompr/R/decomp_gadget.R':

Found the following calls to data() loading into the global environment:
File ‘decompr/R/decomp_gadget.R’:
data(list = paste("wiod", input$wiodselect, sep = ""))
data(leather, package = "decompr")
See section ‘Good practice’ in ‘?data’.

Please note that this is not new behaviour, it is also present in the version currently on CRAN.

I have tried my best to remove any notes, but this one seems impossible to avoid.

This update solve a long list of problems and errors in the version currently on CRAN.
This update solves a long list of problems and errors in the version currently on CRAN.

0 comments on commit 36fc1e2

Please sign in to comment.