Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to a package #26

Closed
cenkalti opened this issue Oct 24, 2018 · 1 comment
Closed

Convert to a package #26

cenkalti opened this issue Oct 24, 2018 · 1 comment

Comments

@cenkalti
Copy link

@br0xen I am using boltdb in one of my projects and I like boltbrowser. I would like to embed boltbrowser into my application binary. To do this, I need to be able to import it as a package. Current package name (main) does not allow me to that. I propose to move all code files except boltbrowser.go into a new package under github.com/br0xen/boltbrowser/boltbrowser. This will not break backwards compatibility and will allow other packages to import boltbrowser as a library. I can send you a PR if it's okay. Are you happy with this change?

@br0xen
Copy link
Owner

br0xen commented Oct 25, 2018

So, a couple of thoughts about this:

  • If I switch this to be a package, along with that comes an expectation of supporting it as a package, I currently don't have the time or desire to do that... Changing any exported things could break any packages that are importing it, then I have to deal with that...
  • I've built everything to be coupled to package main, I'm not sure what all would be required to change that.

Having said all that, it's open source, feel free to grab it and use it however you want!

@br0xen br0xen closed this as completed Oct 25, 2018
backwardn pushed a commit to backwardn/boltbrowser that referenced this issue Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants