Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two commands: convert the ascii to decimal and convert binary to UTC #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sofat1989
Copy link

image

the key 'd': convert the ascii to decimal
image

the key 't': convert the binary to UTC
image

This window's mode is modeBrowse. Using q and esc will quit the program. So here exiting this modeBrowse window needs two steps:

  1. click enter: enter the modeChange window
  2. click q and esc: exit the window

@br0xen
Copy link
Owner

br0xen commented Jul 12, 2019

I like what you've done here, and would like to have more functionality like this, but I don't know that the use-case is universal enough to warrant main key-events...

What I'd rather see for this is something like a 'convert' sub screen that manages these in some way. Maybe even with a workflow like: type a value in the box, specify an external command then boltbrowser passes that to the external app and captures the output to save.

Thanks for the contribution, though! I'm glad that you're getting good usage out of boltbrowser!

@br0xen
Copy link
Owner

br0xen commented Oct 22, 2019

After some discussions that I've had with others I now understand the need for what you're doing. I've created an issue to try to help resolve this. I'll keep this pull request open until I have a solution in place in the main branch.

Thank you again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants