New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect format for user-properties in request #14

Merged

br33f merged 2 commits into br33f:master from mm-sam:master

Oct 24, 2022

Contributor

mm-sam commented Oct 17, 2022

ref:
https://developers.google.com/analytics/devguides/collection/protocol/ga4/user-properties?client_type=gtag#example_usage

fetch(`https://www.google-analytics.com/mp/collect${queryParams}`, {
    method: "POST",
    body: JSON.stringify({
      "client_id": clientId,
      "user_properties": {
        "customer_tier": {
          "value": customerTier
        }
      },
      "events": JSON.parse(events)
    })
  });


          fix incorrect format for user-properties in request

350e486

br33f reviewed

View reviewed changes

src/Dto/Common/UserProperties.php Outdated

-                          return $userProperty->export();
-                      }, $this->getUserPropertiesList());
+                      return array_reduce($this->getUserPropertiesList(), function ($last, UserProperty $userProperty) {
+                          $last[$userProperty->getName()] = [

Owner

br33f Oct 21, 2022

Please use $userProperty->export() instead


          use $userProperty->export() instead

e1e8eca

br33f merged commit a5b45f4 into br33f:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment