Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Alpine Linux #37

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Add support for Alpine Linux #37

merged 3 commits into from
Aug 6, 2021

Conversation

br3ndonland
Copy link
Owner

@br3ndonland br3ndonland commented Aug 6, 2021

- Add `ALPINE_VERSION` build argument, which will be empty by default,
  or prefixed with a `-` if set
- Use `ALPINE_VERSION` to pull Docker image: will look like
  `FROM python:3.9-alpine`
- Use `wget`, which is included with both Debian and Alpine by default,
  instead of `curl`, which is not included with Alpine by default
- Conditionally install build dependencies on Alpine by sourcing
  `/etc/os-release`, which contains `$ID` to indicate the Linux distro
Docker image tags will append `-alpine` for Alpine Linux builds:
`docker pull ghcr.io/br3ndonland/inboard:fastapi-python3.8-alpine`
@vercel
Copy link

vercel bot commented Aug 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/br3ndonland/inboard/8xEiD3CWvvnJK5JzASscEPwtfiC9
✅ Preview: https://inboard-git-alpine-br3ndonland.vercel.app

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #37 (b072c07) into develop (efe50b8) will not change coverage.
The diff coverage is n/a.

❗ Current head b072c07 differs from pull request most recent head 41ae8b6. Consider uploading reports for the commit 41ae8b6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          271       271           
=========================================
  Hits           271       271           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe50b8...41ae8b6. Read the comment docs.

@br3ndonland br3ndonland merged commit 11dc393 into develop Aug 6, 2021
@br3ndonland br3ndonland deleted the alpine branch August 6, 2021 20:14
br3ndonland added a commit that referenced this pull request Aug 14, 2021
#37

Build dependencies were initially left in the Alpine Linux Docker images
because without them, the packages used by inboard cannot be installed
or updated. However, these build dependencies also may not be adequate
to build packages in downstream projects. Each project will likely need
to assemble its own build dependencies.

Rather than retaining build dependencies in the final Docker images,
inboard will remove them after package installs, and document how to
install them again for downstream projects. A subsequent commit will add
documentation about how to install build dependencies on Alpine Linux.
br3ndonland added a commit that referenced this pull request Aug 14, 2021
#37

Each project will likely need to assemble its own build dependencies, so
inboard will document how to install them.
@br3ndonland br3ndonland mentioned this pull request Jul 7, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant