-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TraceCaller interface for extensibility for #104 #106
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
da1e9e9
Add TraceCaller interface for extensibility
StevenACoffman 557f993
Address linter and add another line of coverage
StevenACoffman bd1be4a
Make changes per review
StevenACoffman c102ca8
more review changes
StevenACoffman 28a89e4
Use errors.Unwrap
abhinav 009dfa7
doc(UnwrapFrame): Mention TracePC() uintptr
abhinav eff2d7d
UnwrapFrame: Reuse name "inner"
abhinav c9671b9
test(UnwrapFrame): Verify against custom TracePC
abhinav 1229395
CHANGELOG: Add entry
abhinav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that inner is a better name.
wrapErr
was a silly play onwrapper
, but I still get to giggle when any error name's last syllable can be pronouncederr
. 😄