Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionRequiredMixin docs are inconsistent with upstream behaviour #228

Closed
LegoStormtroopr opened this issue Oct 4, 2017 · 0 comments

Comments

@LegoStormtroopr
Copy link
Contributor

From this: https://django-braces.readthedocs.io/en/latest/access.html#permissionrequiredmixin

This mixin was originally written by Daniel Sokolowski (code here), but this version eliminates an unneeded render if the permissions check fails.

Reviewing the linked code the PermissionRequiredMixin does not do object permissions, while the djang-guardian version does.

This means that PermissionRequired with an UpdateView may incorrectly allow a user through.

Either the documentation should be updated, or the code should. Happy to do a PR.

kennethlove added a commit that referenced this issue Dec 3, 2017
Add object level permissions, fixes #228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant