We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From this: https://django-braces.readthedocs.io/en/latest/access.html#permissionrequiredmixin
This mixin was originally written by Daniel Sokolowski (code here), but this version eliminates an unneeded render if the permissions check fails.
Reviewing the linked code the PermissionRequiredMixin does not do object permissions, while the djang-guardian version does.
PermissionRequiredMixin
This means that PermissionRequired with an UpdateView may incorrectly allow a user through.
Either the documentation should be updated, or the code should. Happy to do a PR.
The text was updated successfully, but these errors were encountered:
be2be87
Merge pull request #229 from LegoStormtroopr/master
9acdf57
Add object level permissions, fixes #228
No branches or pull requests
From this: https://django-braces.readthedocs.io/en/latest/access.html#permissionrequiredmixin
Reviewing the linked code the
PermissionRequiredMixin
does not do object permissions, while the djang-guardian version does.This means that PermissionRequired with an UpdateView may incorrectly allow a user through.
Either the documentation should be updated, or the code should. Happy to do a PR.
The text was updated successfully, but these errors were encountered: