Fix/modernizing-braces #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file could use some refactoring. Maybe split classes out into more files? Almost 500 lines seems like a lot.
The AJAX mixin should probably be deprecated or refactored per the Django docs on is_ajax().
These are pretty good, no real notes on them.
Not much to say here. Some of these seem somewhat limited in use.
Some of these might be better handled with more modern solutions like Prefetch objects.
Codecov Report
@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 97.28% 97.69% +0.41%
==========================================
Files 8 8
Lines 478 477 -1
Branches 69 67 -2
==========================================
+ Hits 465 466 +1
+ Misses 11 9 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The "failed build" is because codecov was unavailable.... |
auvipy
reviewed
Nov 11, 2021
auvipy
reviewed
Nov 11, 2021
Co-authored-by: Cleiton de Lima <CleitonDeLima@users.noreply.github.com>
Co-authored-by: Cleiton de Lima <CleitonDeLima@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276
This PR is a surface refactor of all of the
django-bracescode. This should remove all of the Python 2 considerations and generally just make the code nicer.I'll follow up with tickets for other updates/changes.