Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Weird issue when closing tabs #10459

Open
core-ai-bot opened this issue Aug 30, 2021 · 15 comments
Open

[CLOSED] Weird issue when closing tabs #10459

core-ai-bot opened this issue Aug 30, 2021 · 15 comments

Comments

@core-ai-bot
Copy link
Member

Issue by arashsa
Wednesday Jan 27, 2016 at 16:39 GMT
Originally opened as adobe/brackets#12162


Whenever I have a tab open, and I close it and the file has not been saved, I am asked if I want to save the file, which I do, and what happens is that the content of that file is then copied to another file that also is open. Very strange behaviour. Have never encountered anything similar. Brackets seem to have a lot of issues with files.

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Wednesday Jan 27, 2016 at 16:54 GMT


@arashsa Do you see the same tab appearing twice which seems like 2 entries of the same file?

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Wednesday Jan 27, 2016 at 17:03 GMT


If this is not related to the same doc both views-feature...:

@swmitra I have sometimes ran into a situation where the title bar shows foo.js but the file contents are of bar.js which was open on the pane previously. See the last part of this:

adobe/brackets#11820 (comment)

I have ran into it once or twice after that, but I haven't been able to repeat it. It could be related to adobe/brackets#11826 though too.

@core-ai-bot
Copy link
Member Author

Comment by arashsa
Wednesday Jan 27, 2016 at 17:07 GMT


@swmitra No, the actual content of one file gets copied over to another file. Has been happening a few times lately. Very annoying, and when it happens, sometimes I can't the the old content back, and need to pull the file from git.

@petetnt Does not seem to be related.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Wednesday Jan 27, 2016 at 17:18 GMT


@arashsa Then it seems to be the thing I described in adobe/brackets#11820 (comment).

You don't actually lose the contents until you save the file (the document isn't marked dirty either), but if you make a change it does lead to data loss which sucks.

@core-ai-bot
Copy link
Member Author

Comment by arashsa
Wednesday Jan 27, 2016 at 17:24 GMT


@petetnt No, not really. You are describing changes to the same file in two different panes, I am having issues with two separate files, which is very strange. And these files are not open in different panes, but in different tabs. So let's say I change something in one scss file (only experienced this with scss files), and then I don't save it, but close the tab, then say yes to the popup that asks to save, then another file that is opened suddenly is overwritten with the content of the file I just closed. I think it has been the file that gets open after I have closed the other file.

This seems somewhat unrelated to your issue, no?

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Wednesday Jan 27, 2016 at 17:29 GMT


@arashsa Actually that's the exact scenario I am facing, the wording here is kinda bad (the header is flipper around: it should say that title changes but the contents are the same) though:

Haven't been able to repeat this in a repeatable manner, but sometimes when closing files that are duplicated, pane text and the contents of the file don't match. Might be related to the working set behavior. Saving the file in this state brings tons of unsuspected behaviors.

For example if I close foo.scss, pane header shows bar.scss but the file contents are of foo.scss. If I close Brackets the bar.scss contents haven't actually changed.

@core-ai-bot
Copy link
Member Author

Comment by arashsa
Wednesday Jan 27, 2016 at 17:32 GMT


@petetnt Oh, sorry about that. So, any solutions?

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Wednesday Jan 27, 2016 at 17:40 GMT


@petetnt@arashsa let me see, if I can repro this then work on the solution tonight.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Wednesday Jan 27, 2016 at 17:43 GMT


I tried to repro this for a while just now but couldn't. Hopefully you have better luck

@core-ai-bot
Copy link
Member Author

Comment by adriennn
Friday Jan 29, 2016 at 22:37 GMT


I have the same problem. Just updated to 1.6 on Ubuntu 14.04 and anytime I make a modification to an opened file, it opens a new tab when upon saving.

edit: looks like a css issue (see the new styles), because I don't see those new styles.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Saturday Jan 30, 2016 at 07:20 GMT


@adriennn The flip-view buttons, by default, are visible when hovering over the header bar (you can toggle that from preferences).

The other thing might be due to adobe/brackets#11820 ?

If not, can you provide some screens how your panes look like after saving (and what is the expected outcome)

@core-ai-bot
Copy link
Member Author

Comment by adriennn
Saturday Jan 30, 2016 at 11:56 GMT


hey@petetnt,
after trying some stuff, I finally realize it was down to the "Documents Toolbar" extension (I forgot brackets didn't have the file tabs above the panels by default), so I guess I'll revert to 1.5 until that extension is fixed. see issue. So my issue wasn't the same as@arashsa, I got confused with his mention of tabs.

@core-ai-bot
Copy link
Member Author

Comment by dnbard
Wednesday Feb 03, 2016 at 09:41 GMT


Looks like Brackets events aren't sent anymore in Brackets v1.6.0.

I can reproduce the issue with API I'm using:
brackets issue

workingSetRemove event aren't triggered when file was removed from working files list - file is still in the list event after Close menu item was selected.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Wednesday Feb 03, 2016 at 09:48 GMT


@dnbard There's a fix tracking at #12145

@core-ai-bot
Copy link
Member Author

Comment by abose
Thursday Feb 25, 2016 at 09:11 GMT


A build refresh is scheduled by his week or next for 1.6 and after that the new installers posted will contain this fix.
Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant