Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets 1.6 issue - Close button not working #62

Closed
djAjax opened this issue Jan 21, 2016 · 15 comments
Closed

Brackets 1.6 issue - Close button not working #62

djAjax opened this issue Jan 21, 2016 · 15 comments

Comments

@djAjax
Copy link

djAjax commented Jan 21, 2016

In Brackets v.1.6 close button not working.
screenshot_2

@paulmz
Copy link

paulmz commented Jan 21, 2016

I had the same issue. I rolled-back Brackets to 1.5 until this is fixed. Tabs are way more important for me than any of the new Brackets features.

@hakoiko
Copy link

hakoiko commented Jan 22, 2016

image
same issue and more here.
1.same document is opened both left&right or top&bottom panel.
2.close the document (with cmd+w). but I can't.
3.select the document on sidebar.
4.the tab has multiplied!!!
5.close the document with X button of sidebar (not both but one panel)
6.in another panel, the document is still opened. but the tab header disappeared from document toolbar both top&bottom panel.

@PatrickdeBie
Copy link

Same issue here.
Temporarily workaround: use middle mouse button (Windows 7, not tested on other systems) to close tabs.

--edit--
Not a 100% workaround. I've got some weird behaviour with the content of tabs while using this. I've not been able to get a solid reproduction plan for this.

@geoffatcircle
Copy link

Same issue here! I'd love to tackle this myself if I get the time.

@GlobeTechGit
Copy link

Middle mouse button works fine in Windows 8. Thanks for the workaround.

@dnbard
Copy link
Owner

dnbard commented Feb 2, 2016

Looks like Brackets events aren't sent anymore in Brackets v1.6.0.

I can reproduce the issue with API I'm using:
brackets issue

workingSetRemove event aren't triggered when file was removed from working files list - file is still in the list event after Close menu item was selected.

@dnbard
Copy link
Owner

dnbard commented Feb 2, 2016

Also, you can hide close buttons and working files list from the options panel that is accessible from context menu:

2016-02-02_1116

@awojtas
Copy link

awojtas commented Feb 3, 2016

I went to Extension Options and I get the following (empty UI):

2016-02-03 16_47_29-lftdevtheme2 css software - brackets

@dinosaurfiles-zz
Copy link

bump for this. Linux Mint 17.3, Brackets 1.6

@taniarascia
Copy link

+1 I'm using Custom Working Tabs for now.

@haizdesign
Copy link

Any news? Thanks taniarascia for the suggestion.

@charlesmigrino
Copy link

+1 Having this issue as well. So far, only middle mouse works well (Mac). Command + W (Ctrl + W) also closes the document but leaves the tab on top.

screen shot 2016-03-10 at 10 04 04 am

@edamon
Copy link

edamon commented Mar 26, 2016

+1

@miltonsiqueira
Copy link
Contributor

Thanks @PatrickdeBie for your middle mouse button suggestion.

I've tried to figured out this issue comparing the middle mouse and close button.
Both call the function onDocumentClose in the documents.js.

this.onDocumentClose = function(file){
    if (!!_.find(self.locked(), function(lockedDocumentPath){
        return lockedDocumentPath === file._path;
    })){
        return false;
    }

    CommandManager.execute('file.close', {
        file: file,
        paneId: this.panelId
    });
}

So, if I use the mouse middle button the this.panelId is "first-pane",
but for close button it's undefined.
Therefore, when this snippet is changed as below, the close button have the same middle mouse button behaviour.

CommandManager.execute('file.close', {
    file: file,
    paneId: this.panelId || 'first-pane'
});

I think it seems more a workaround than a solution and must be better understand where this.panelId is changed. And it's not resolve the problem with Command + W (Ctrl + W).

@miltonsiqueira
Copy link
Contributor

Actually, the correction must be to use self.panelId instead of this.panelId:

CommandManager.execute('file.close', {
    file: file,
    paneId: self.panelId
});

But the Command + W (Ctrl + W) persists. Should do I pull request it and open another issue regarding the close shortcut or try to fix it and pull request both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests