-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brackets 1.6 issue - Close button not working #62
Comments
I had the same issue. I rolled-back Brackets to 1.5 until this is fixed. Tabs are way more important for me than any of the new Brackets features. |
Same issue here. --edit-- |
Same issue here! I'd love to tackle this myself if I get the time. |
Middle mouse button works fine in Windows 8. Thanks for the workaround. |
bump for this. Linux Mint 17.3, Brackets 1.6 |
+1 I'm using Custom Working Tabs for now. |
Any news? Thanks taniarascia for the suggestion. |
+1 |
Thanks @PatrickdeBie for your middle mouse button suggestion. I've tried to figured out this issue comparing the middle mouse and close button. this.onDocumentClose = function(file){
if (!!_.find(self.locked(), function(lockedDocumentPath){
return lockedDocumentPath === file._path;
})){
return false;
}
CommandManager.execute('file.close', {
file: file,
paneId: this.panelId
});
} So, if I use the mouse middle button the CommandManager.execute('file.close', {
file: file,
paneId: this.panelId || 'first-pane'
}); I think it seems more a workaround than a solution and must be better understand where |
Actually, the correction must be to use CommandManager.execute('file.close', {
file: file,
paneId: self.panelId
}); But the Command + W (Ctrl + W) persists. Should do I pull request it and open another issue regarding the close shortcut or try to fix it and pull request both? |
In Brackets v.1.6 close button not working.
![screenshot_2](https://cloud.githubusercontent.com/assets/9333602/12482656/81bb6034-c059-11e5-8c66-138700108c4c.png)
The text was updated successfully, but these errors were encountered: