Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] fix invalid filename #10850

Open
core-ai-bot opened this issue Aug 30, 2021 · 4 comments
Open

[CLOSED] fix invalid filename #10850

core-ai-bot opened this issue Aug 30, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by zaggino
Monday Aug 29, 2016 at 04:33 GMT
Originally opened as adobe/brackets#12732

mentioned here adobe/brackets#11569

(passes on windows due to fs being case insensitive)

file here: https://github.com/adobe/brackets/blob/master/test/spec/CodeHint-test-files/testRegExp.js

cc@MarcelGerber@ficristo

zaggino included the following code: https://github.com/adobe/brackets/pull/12732/commits
@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Monday Aug 29, 2016 at 09:13 GMT

What's weird is that these tests passed before with this exact same invalid filename in place, but merging anyway :)

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Monday Aug 29, 2016 at 09:22 GMT

This doesn't fix the tests in Extensions \ JavaScript Code Hinting for me.
But it is a good cleanup anyway.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Monday Aug 29, 2016 at 10:01 GMT

Tests still fail for me, too (Linux).@ficristo Do you also get the message timeout: timed out after 1000 msec waiting for success [undefined]?

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Monday Aug 29, 2016 at 10:13 GMT

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot