Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

fix invalid filename #12732

Merged
merged 1 commit into from
Aug 29, 2016
Merged

fix invalid filename #12732

merged 1 commit into from
Aug 29, 2016

Conversation

zaggino
Copy link
Contributor

@zaggino zaggino commented Aug 29, 2016

mentioned here #11569

(passes on windows due to fs being case insensitive)

file here: https://github.com/adobe/brackets/blob/master/test/spec/CodeHint-test-files/testRegExp.js

cc @marcelgerber @ficristo

@zaggino zaggino mentioned this pull request Aug 29, 2016
@zaggino zaggino added this to the Release 1.8 milestone Aug 29, 2016
@marcelgerber
Copy link
Contributor

What's weird is that these tests passed before with this exact same invalid filename in place, but merging anyway :)

@marcelgerber marcelgerber merged commit 1342b4c into master Aug 29, 2016
@marcelgerber marcelgerber deleted the zaggino/fix-codehints-tests branch August 29, 2016 09:13
@ficristo
Copy link
Collaborator

This doesn't fix the tests in Extensions \ JavaScript Code Hinting for me.
But it is a good cleanup anyway.

@marcelgerber
Copy link
Contributor

Tests still fail for me, too (Linux). @ficristo Do you also get the message timeout: timed out after 1000 msec waiting for success [undefined]?

@ficristo
Copy link
Collaborator

Yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants