Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dark shell] Auto-hide Windows Taskbar does not show when Brackets is maximized #12626

Open
core-ai-bot opened this issue Aug 31, 2021 · 30 comments
Open

[dark shell] Auto-hide Windows Taskbar does not show when Brackets is maximized #12626

core-ai-bot opened this issue Aug 31, 2021 · 30 comments

Comments

@core-ai-bot
Copy link
Member

Issue by dexbg
Thursday Apr 17, 2014 at 14:31 GMT
Originally opened as adobe/brackets#7555

My Windows Taskbar is set to auto-hide and when Brackets is on focus (and maximized) the Taskbar cannot be activated when I move the mouse at the bottom of the screen. This is annoying since switching to other applications cannot be done by using the mouse but only with the keyboard.
@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Thursday Apr 17, 2014 at 14:58 GMT

I can repro this.
Windows 8.1 Update 1

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Apr 17, 2014 at 15:10 GMT

I also see this, but only see this when Brackets window is maximized. Is anyone seeing this when window is not maximized?

@core-ai-bot
Copy link
Member Author

Comment by dexbg
Thursday Apr 17, 2014 at 15:16 GMT

Yes, when the Brackets window is not maximized the same problem occurs. However, there is workaround in non-maximized mode - if you change the focus to other application and go back to Brackets - the problem is gone.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Apr 17, 2014 at 20:56 GMT

It seems to be introduced by this pull request. I can't reproduce it with sprint 35 shell, but can reproduce with later sprint shell. It seems like the fix for #5323 has extended the window height to the very bottom most pixel and therefore the one-pixel required to invoke the task bar is no longer available.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday Apr 18, 2014 at 01:18 GMT

Nominating for 1.0 and assigning@JeffryBooher

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 21, 2014 at 18:44 GMT

Reviewed.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Monday Apr 21, 2014 at 18:45 GMT

Load balancing to@RaymondLim. Ping me if you need help.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Apr 21, 2014 at 21:14 GMT

Clarifying title to help catch dupes (was: "The Windows Taskbar cannot be activated when Brackets is on focus")

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Thursday May 01, 2014 at 16:23 GMT

Reviewed leave the 1.0 milestone.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday May 02, 2014 at 16:43 GMT

https://github.com/MahApps/MahApps.Metro/blob/master/MahApps.Metro/Behaviours/BorderlessWindowBehavior.cs

Look at private void HandleMaximize(bool handleOnlyMaximized = false) I'd try something like that or you could just not paint pixels that overlap the hidden taskbar by getting the workarea and figuring out where the hidden taskbar is when Brackets is maximized

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday May 13, 2014 at 22:12 GMT

This should be fixed with Release 39

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday May 13, 2014 at 22:37 GMT

This is not fixed for me on Win7 in master.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday May 13, 2014 at 22:44 GMT

Reassigning to@RaymondLim who has a fix for it.

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Wednesday Aug 13, 2014 at 18:38 GMT

@RaymondLim if this is lower effort we still want to do this for release 44, otherwise later.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Aug 13, 2014 at 19:03 GMT

I don't have a fix yet. So it's not a low effort.

@core-ai-bot
Copy link
Member Author

Comment by MartinMa
Thursday Aug 14, 2014 at 07:24 GMT

Maybe this helps hwnd_message_handler.cc line 1648. It's how Chromium seems to handle it.

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Monday Aug 18, 2014 at 18:15 GMT

@JeffryBooher will play with@MartinMa 's code / proposal.

@core-ai-bot
Copy link
Member Author

Comment by msacchetti
Wednesday Sep 24, 2014 at 20:00 GMT

This is driving me nuts, completely killing my workflow having to alt+tab out of brackets every time. Windows 7 latest sprint.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Oct 16, 2014 at 18:54 GMT

I confirmed on Win7. Should be tested on Win8.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Oct 21, 2014 at 23:30 GMT

@MarcelGerber Can you test this on Windows 8.1 ?

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Wednesday Oct 22, 2014 at 14:46 GMT

@redmunds Works fine on Win 8.1 either.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Oct 22, 2014 at 14:49 GMT

@bchintx you wanna take it for a spin and then close it as fixed if you don't see any isssues?

@core-ai-bot
Copy link
Member Author

Comment by bchintx
Wednesday Oct 22, 2014 at 22:28 GMT

@JeffryBooher Looks fixed with Brackets maximized on my Win 8.1 desktop. Unfortunately, it's still not fixed on my Surface Pro (1st gen), also running 8.1. On my Surface Pro, I don't see the 1px sliver of space along the bottom of the maximized Brackets window, like I do on my desktop. Perhaps that why the taskbar isn't re-appearing?

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Oct 22, 2014 at 22:32 GMT

Marking this one needs review. It is fixed on desktops (verified on Windows 7 and 8.1 by 4 different users) @bchintx is still seeing an issue with it on a Surface Pro (1st generation model). I don't have access to one of those to test with and see where it falls apart.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Oct 22, 2014 at 23:30 GMT

@redmunds there is a fix that I found for@bchintx surface.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Oct 23, 2014 at 01:35 GMT

@JeffryBooher Fix is merged.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Thursday Oct 23, 2014 at 04:09 GMT

@bchintx this is ready for you to test but you should test it on your surface and 8.1 desktop from the nightly build tomorrow.

@core-ai-bot
Copy link
Member Author

Comment by bchintx
Thursday Oct 23, 2014 at 15:43 GMT

Installed the Brackets nightly build 0.45.0-15045, and I'm able to access the auto-hidden taskbar from both the bottom- and right-sides (when configured as such) while Brackets is maximized. Running Windows 8.1 on Surface Pro.

Thanks,@JeffryBooher !

@core-ai-bot
Copy link
Member Author

Comment by tanguyvda
Tuesday Aug 04, 2015 at 12:54 GMT

Windows : 8.1
Brackets : Version 1.4 édition 1.4.0-16380 (release 273804eb3)
Computer : asus UX301LA

Taskbar is still locked down while Brackets is maximized using auto-hide feature from windows. Doesn't work neither from the bottom nor the other sides. I need to press windows key or minimize brackets to make it shows up.

edit : still having this issue on windows 10

@core-ai-bot
Copy link
Member Author

Comment by cozzbie
Friday Jan 15, 2016 at 23:29 GMT

Have this issue on windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot