[dark shell] Auto-hide Windows Taskbar does not show when Brackets is maximized

[dexbg]

My Windows Taskbar is set to auto-hide and when Brackets is on focus (and maximized) the Taskbar cannot be activated when I move the mouse at the bottom of the screen. This is annoying since switching to other applications cannot be done by using the mouse but only with the keyboard.

[marcelgerber]

I can repro this.
Windows 8.1 Update 1

[redmunds]

I also see this, but only see this when Brackets window is maximized. Is anyone seeing this when window is not maximized?

[dexbg]

Yes, when the Brackets window is not maximized the same problem occurs. However, there is workaround in non-maximized mode - if you change the focus to other application and go back to Brackets - the problem is gone.

[RaymondLim]

It seems to be introduced by this pull request. I can't reproduce it with sprint 35 shell, but can reproduce with later sprint shell. It seems like the fix for #5323 has extended the window height to the very bottom most pixel and therefore the one-pixel required to invoke the task bar is no longer available.

[peterflynn]

Nominating for 1.0 and assigning @JeffryBooher

[njx]

Reviewed.

[JeffryBooher]

Load balancing to @RaymondLim. Ping me if you need help.

[peterflynn]

Clarifying title to help catch dupes (was: "The Windows Taskbar cannot be activated when Brackets is on focus")

[pthiess]

Reviewed leave the 1.0 milestone.

[JeffryBooher]

https://github.com/MahApps/MahApps.Metro/blob/master/MahApps.Metro/Behaviours/BorderlessWindowBehavior.cs

Look at private void HandleMaximize(bool handleOnlyMaximized = false) I'd try something like that or you could just not paint pixels that overlap the hidden taskbar by getting the workarea and figuring out where the hidden taskbar is when Brackets is maximized

[JeffryBooher]

This should be fixed with Release 39

[redmunds]

This is not fixed for me on Win7 in master.

[JeffryBooher]

Reassigning to @RaymondLim who has a fix for it.

[redmunds]

@marcelgerber Can you test this on Windows 8.1 ?

[marcelgerber]

@redmunds Works fine on Win 8.1 either.

[JeffryBooher]

@bchintx you wanna take it for a spin and then close it as fixed if you don't see any isssues?

[bchintx]

@JeffryBooher Looks fixed with Brackets maximized on my Win 8.1 desktop. Unfortunately, it's still not fixed on my Surface Pro (1st gen), also running 8.1. On my Surface Pro, I don't see the 1px sliver of space along the bottom of the maximized Brackets window, like I do on my desktop. Perhaps that why the taskbar isn't re-appearing?

[JeffryBooher]

Marking this one needs review. It is fixed on desktops (verified on Windows 7 and 8.1 by 4 different users) @bchintx is still seeing an issue with it on a Surface Pro (1st generation model). I don't have access to one of those to test with and see where it falls apart.

[JeffryBooher]

@redmunds there is a fix that I found for @bchintx surface.

[redmunds]

@JeffryBooher Fix is merged.

[JeffryBooher]

@bchintx this is ready for you to test but you should test it on your surface and 8.1 desktop from the nightly build tomorrow.

[bchintx]

Installed the Brackets nightly build 0.45.0-15045, and I'm able to access the auto-hidden taskbar from both the bottom- and right-sides (when configured as such) while Brackets is maximized. Running Windows 8.1 on Surface Pro.

Thanks, @JeffryBooher !

[tanguyvda]

Windows : 8.1
Brackets : Version 1.4 édition 1.4.0-16380 (release 273804e)
Computer : asus UX301LA

Taskbar is still locked down while Brackets is maximized using auto-hide feature from windows. Doesn't work neither from the bottom nor the other sides. I need to press windows key or minimize brackets to make it shows up.

edit : still having this issue on windows 10

[cozzbie]

Have this issue on windows 10

[ghost]

Just FYI... Still have this issue on Windows 7 with the latest release:/

[Mabjic]

I have the problem on Windows 10, I got the latest release of Brackets, the issue needs to be re-opened...

[m5signorini]

Having the same problem on Windows 10 using Brackets 1.10

[nkizito92]

I'm Have the same problem too and its Sep 3, 2018

[marcomow]

issue still here, windows 10 today

[petterwr]

+1 windows 10