Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] URL formatting when wrapping lines can be better #1566

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments
Open

[CLOSED] URL formatting when wrapping lines can be better #1566

core-ai-bot opened this issue Aug 29, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Sunday Sep 09, 2012 at 20:17 GMT
Originally opened as adobe/brackets#1604


This issue was split from #1565. This applies to the Quick Open list, Find in Files Results, any error dialog that displays a URL, and maybe more places.

When displaying URLs, the default way that they wrap is terrible. Basically, lines are only broken on hyphens and spaces. Possible solutions:

(a) breaking on any character using this technique: http://perishablepress.com/wrapping-content/

(b) make it break on path separators (but still not break on any/all chars) which might be relatively easy if we can just inject "zero-width space" chars or some such in the display string... e.g. http://stackoverflow.com/questions/2046530/whats-the-opposite-of-a-nbsp

(c) some form of smart truncation (some native apps preserve the start & end of the path, but replace the middle with ellipses).

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Wednesday Sep 12, 2012 at 16:37 GMT


Reviewed -@redmunds - Randy this may be a starter bug, please review.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Sep 12, 2012 at 16:54 GMT


Yes, I agree that this would make a good starter bug.

@core-ai-bot
Copy link
Member Author

Comment by JakeStoeffler
Saturday Oct 06, 2012 at 07:58 GMT


@redmunds@pthiess - I'm new to Brackets and I'm considering taking this one. Solutions (a) and (b) seemed simple so I gave them a shot. Here's what the Quick Open list looks like with solution (a) and solution (b). Option (c) is going to be a bit trickier, but personally I prefer to see the whole file path so I'm thinking (a) or (b) might be better. What do you guys think?

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Saturday Oct 06, 2012 at 19:37 GMT


@jakestoeffler - Thanks for taking this on!@pthiess,@peterflynn, and I all prefer option (b). Please submit a pull request.

I'd also like to note that there are other places in the UI where we'd also like to have this functionality. For example, edit a file, then close it without saving, and you'll get a dialog about the unsaved changes with the full url to the file displayed in that dialog. So, try to make the solution as generic as possible.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Sunday Oct 07, 2012 at 23:19 GMT


Fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant