[CLOSED] Call new shell api setModal to enforce the modality of a JS dialog.

[core-ai-bot]

Issue by RaymondLim
Tuesday Jun 25, 2013 at 21:28 GMT
Originally opened as adobe/brackets#4341

---

This pull request goes with another one in brackets shell adobe/brackets-shell#268.

Also remove all the hacks that we put in when switching to native menus. So after this pull request landed, we need to regress #2616, #3152, #3219 and #418.

---

RaymondLim included the following code: https://github.com/adobe/brackets/pull/4341/commits

[core-ai-bot]

Comment by njx
Wednesday May 14, 2014 at 18:31 GMT

---

@RaymondLim@gruehle - looks like we never merged this and the associated shell PR. I have a vague recollection that we had some concerns with it, but it doesn't look like anyone ever commented on why. Do you guys remember where we ended up?

[core-ai-bot]

Comment by gruehle
Wednesday May 14, 2014 at 19:42 GMT

---

We wanted to investigate general command enabling/disabling to make sure it didn't conflict with this pull request.

We discussed this at an architecture meeting. I don't remember coming to any conclusions about command enabling/disabling, but I'm pretty sure we decided that a modal switch would not conflict.@RaymondLim does that sound right?

[core-ai-bot]

Comment by dangoor
Wednesday Nov 19, 2014 at 15:13 GMT

---

@RaymondLim I think we should probably close this PR. If you'd like to get this in, I'd recommend rebasing with current master and submitting a separate PR.

Does that make sense to you?

[core-ai-bot]

Comment by RaymondLim
Friday Jan 09, 2015 at 17:48 GMT

---

Closing for now.