Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Call new shell api setModal to enforce the modality of a JS dialog. #4341

Closed
wants to merge 2 commits into from

Conversation

RaymondLim
Copy link
Contributor

This pull request goes with another one in brackets shell adobe/brackets-shell#268.

Also remove all the hacks that we put in when switching to native menus. So after this pull request landed, we need to regress #2616, #3152, #3219 and #418.

@njx
Copy link
Contributor

njx commented May 14, 2014

@RaymondLim @gruehle - looks like we never merged this and the associated shell PR. I have a vague recollection that we had some concerns with it, but it doesn't look like anyone ever commented on why. Do you guys remember where we ended up?

@gruehle
Copy link
Member

gruehle commented May 14, 2014

We wanted to investigate general command enabling/disabling to make sure it didn't conflict with this pull request.

We discussed this at an architecture meeting. I don't remember coming to any conclusions about command enabling/disabling, but I'm pretty sure we decided that a modal switch would not conflict. @RaymondLim does that sound right?

@dangoor
Copy link
Contributor

dangoor commented Nov 19, 2014

@RaymondLim I think we should probably close this PR. If you'd like to get this in, I'd recommend rebasing with current master and submitting a separate PR.

Does that make sense to you?

@RaymondLim
Copy link
Contributor Author

Closing for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants