Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Code cleanup: Consistent naming for CSS classes/IDs #406

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

[CLOSED] Code cleanup: Consistent naming for CSS classes/IDs #406

core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by njx
Tuesday Mar 06, 2012 at 20:25 GMT
Originally opened as adobe/brackets#408


Currently in we have a mix of CSS classes/ids named with hyphens (e.g. .dummy-text) and named in camel-case (e.g. .inlineCodeEditor). We should have a consistent style for these.

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Mar 20, 2012 at 18:30 GMT


QRB reviewed. Marking code cleanup.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Monday Apr 30, 2012 at 16:09 GMT


We also need to review the style sheet structure. We currently have a mixture of overlapping organizational patterns:

  • by Framework (brackets_codemirror_override.less)
  • by component (jsTreeTheme.less)
  • by LESS functional type (brackets_variables.less)
  • by presentational type (brackets_colors.less)

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday May 08, 2012 at 17:31 GMT


Assigning to Randy. Let's go with hyphens for everything, including mixins and variable names.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday May 10, 2012 at 22:26 GMT


There's really nothing to confirm, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant