Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Add third-party and CC-BY license URLs for 'tr' locale #4444

Open
core-ai-bot opened this issue Aug 29, 2021 · 6 comments
Open

[CLOSED] Add third-party and CC-BY license URLs for 'tr' locale #4444

core-ai-bot opened this issue Aug 29, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by maleeb
Saturday Aug 17, 2013 at 10:27 GMT
Originally opened as adobe/brackets#4808



maleeb included the following code: https://github.com/adobe/brackets/pull/4808/commits

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Aug 20, 2013 at 00:25 GMT


Review complete. I can merge this when you've made these changes. Thanks.

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Sep 04, 2013 at 21:39 GMT


Oh, it looks like you also need to add an entry for this in nls/urls.js.@jasonsanjose is that right?

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Wednesday Sep 04, 2013 at 21:53 GMT


Yep. Had to do that for Finnish here adobe/brackets#5038.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Sep 23, 2013 at 23:03 GMT


This looks fine, but it turns out that the two links actually don't work in the About dialog because the links are actually incorrect in the strings file.

I'm going to fix that, then squash all these commits into a single update.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Sep 23, 2013 at 23:08 GMT


Actually, it looks like we don't even have a translation for ABOUT_TEXT_WEB_PLATFORM_DOCS in the Turkish strings file, so that URL will never show up in the UI. I'll go ahead and push the other stuff.

@Cryptexx - would you consider updating the Turkish strings.js file with translations for new strings since the last time it was updated? If so, please put up a new pull request for that. Thanks.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Sep 23, 2013 at 23:10 GMT


Merged via 4f53324; see also 63817ff. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant