Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Add third-party and CC-BY license URLs for 'tr' locale #4808

Closed
wants to merge 6 commits into from
Closed

Add third-party and CC-BY license URLs for 'tr' locale #4808

wants to merge 6 commits into from

Conversation

maleeb
Copy link
Contributor

@maleeb maleeb commented Aug 17, 2013

No description provided.

@ghost ghost assigned njx Aug 19, 2013

define({
// Relative to the samples folder
"GETTING_STARTED" : "tr/Erste Schritte",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed since there isn't any such sample currently. (It will fall back to the default English sample.)

@njx
Copy link
Contributor

njx commented Aug 20, 2013

Review complete. I can merge this when you've made these changes. Thanks.

@njx
Copy link
Contributor

njx commented Sep 4, 2013

Oh, it looks like you also need to add an entry for this in nls/urls.js. @jasonsanjose is that right?

@jasonsanjose
Copy link
Member

Yep. Had to do that for Finnish here #5038.

@njx
Copy link
Contributor

njx commented Sep 23, 2013

This looks fine, but it turns out that the two links actually don't work in the About dialog because the links are actually incorrect in the strings file.

I'm going to fix that, then squash all these commits into a single update.

@njx
Copy link
Contributor

njx commented Sep 23, 2013

Actually, it looks like we don't even have a translation for ABOUT_TEXT_WEB_PLATFORM_DOCS in the Turkish strings file, so that URL will never show up in the UI. I'll go ahead and push the other stuff.

@Cryptexx - would you consider updating the Turkish strings.js file with translations for new strings since the last time it was updated? If so, please put up a new pull request for that. Thanks.

@njx
Copy link
Contributor

njx commented Sep 23, 2013

Merged via 4f53324; see also 63817ff. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants