Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] JS Code Hints automatic crash preventer #7437

Open
core-ai-bot opened this issue Aug 30, 2021 · 0 comments
Open

[CLOSED] JS Code Hints automatic crash preventer #7437

core-ai-bot opened this issue Aug 30, 2021 · 0 comments

Comments

@core-ai-bot
Copy link
Member

Issue by dangoor
Monday Jul 07, 2014 at 16:42 GMT
Originally opened as adobe/brackets#8326


This is copied from the card in Trello for tracking in Waffle.

Tern will sometimes spiral out of control on certain JavaScript files. This causes tremendously slowed down performance (because Tern will consume 100% of CPU at those times) and eventually a crash because memory is completely consumed.

We want to automatically stop hinting for these problematic files.

Once we've done this, we can probably remove the line count limit because the problems we see are less likely about number of lines and more likely about the nature of the JS being analyzed.

Criteria

  • Detect that a file has caused Tern to enter this state
  • Terminate the worker (ideally, if this is not possibly, detect the problem at startup)
  • Notify the user that hinting is being turned off for the JS file and suggest that they consider reporting an issue.
  • save an exclusion to .brackets.json
  • Experiment with removing the LARGE_LINE_COUNT maximum

Related Bugs

This list, at least. There are certainly more:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant