Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

JS Code Hints automatic crash preventer #8326

Closed
dangoor opened this issue Jul 7, 2014 · 1 comment
Closed

JS Code Hints automatic crash preventer #8326

dangoor opened this issue Jul 7, 2014 · 1 comment
Assignees

Comments

@dangoor
Copy link
Contributor

dangoor commented Jul 7, 2014

This is copied from the card in Trello for tracking in Waffle.

Tern will sometimes spiral out of control on certain JavaScript files. This causes tremendously slowed down performance (because Tern will consume 100% of CPU at those times) and eventually a crash because memory is completely consumed.

We want to automatically stop hinting for these problematic files.

Once we've done this, we can probably remove the line count limit because the problems we see are less likely about number of lines and more likely about the nature of the JS being analyzed.

Criteria

  • Detect that a file has caused Tern to enter this state
  • Terminate the worker (ideally, if this is not possibly, detect the problem at startup)
  • Notify the user that hinting is being turned off for the JS file and suggest that they consider reporting an issue.
  • save an exclusion to .brackets.json
  • Experiment with removing the LARGE_LINE_COUNT maximum

Related Bugs

This list, at least. There are certainly more:

@njx
Copy link
Contributor

njx commented Jul 10, 2014

Assigning to @dangoor since you're assigned to review the associated PR (and this was showing as unassigned on the Waffle board)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants