Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Inline Editor: make sure cursor is visible after a change event is received #859

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by gruehle
Friday May 11, 2012 at 15:07 GMT
Originally opened as adobe/brackets#864


Fixes issue #752.

When a change event for an inline editor is received, make sure the cursor is visible after all other updates. This fixes two problems:

  1. the cursor is now visible after pasting text that overflows beyond the bottom of the editor
  2. the scroll position of the outer editor was being left in an inconsistent (and incorrect) state

gruehle included the following code: https://github.com/adobe/brackets/pull/864/commits

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Friday May 11, 2012 at 15:28 GMT


reviewing

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Friday May 11, 2012 at 16:04 GMT


Maybe it would be a good time to fill in the comment above the _updateRelatedContainer() function?

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Friday May 11, 2012 at 16:32 GMT


Comment added.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Friday May 11, 2012 at 16:34 GMT


Looks good. Verified fix on Win7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant