This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Inline Editor: make sure cursor is visible after a change event is received #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewing |
|
Maybe it would be a good time to fill in the comment above the _updateRelatedContainer() function? |
|
Comment added. |
|
Looks good. Verified fix on Win7. |
redmunds
added a commit
that referenced
this pull request
May 11, 2012
Inline Editor: make sure cursor is visible after a change event is received
gideonthomas
pushed a commit
to gideonthomas/brackets
that referenced
this pull request
Aug 31, 2017
this updates the code such that it aligns with the code comment explaining what's supposed to happen.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #752.
When a change event for an inline editor is received, make sure the cursor is visible after all other updates. This fixes two problems: