Added Git-FTP init support. #308
Conversation
|
Could you try creating a new less stylesheet in On a second thought, don't do that now. We can't use imports yet (Solved in Sprint 38) |
| .on("click", ".gitftp-remove-remote", function () { handleGitFtpRemoteRemove($(this)); }) | ||
| .on("click", ".gitftp-remote-new", handleGitFtpScopeCreation) | ||
| .on("click", ".gitftp-remove-remote", function () { handleGitFtpScopeRemove($(this)); }) | ||
| .on("click", ".gitftp-init-remote", function () { handleGitFtpInitScope($(this)); }) |
There was a problem hiding this comment.
These handlers should be called the same way (chose one). Currently gitftp-remote-new is different from gitftp-remove-remote and gitftp-init-remote
There was a problem hiding this comment.
Why? I don't need $(this) in handleGitFtpScopeCreation
There was a problem hiding this comment.
You can just rename the other two to
.on("click", ".gitftp-remove-remote", handleGitFtpScopeRemove)
and on the first line do
var $this = $(this);
OR have
.on("click", ".gitftp-remote-new", function () { handleGitFtpScopeCreation(); })
It looks more consistent this way. That's all.
Having .on("click", ".gitftp-remote-new", handleGitFtpScopeCreation) makes me think you want to pass the event from jQuery into arguments
|
Review done. Just minor stuff, quite nice 👍 |
|
Okay I've already prepared the ftp.less file and improved quality of less code. |
|
@FezVrasta I don't mind you rewriting the stylesheet but directives |
|
Whoa - finally ;-) Successful merge all through Brackets! |
|
And please @FezVrasta really update the Changelog in PR's - I'll fix the English if it's bad. Users should know when you add a new stuff. |
Ready for review.