Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN package check failing #40

Closed
5 of 6 tasks
mbcann01 opened this issue Mar 16, 2023 · 0 comments
Closed
5 of 6 tasks

CRAN package check failing #40

mbcann01 opened this issue Mar 16, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mbcann01
Copy link
Member

mbcann01 commented Mar 16, 2023

Overview

On 2023-03-08 I received an email from Kurt Hornik (CRAN) letting me know that codebookr was no longer passing an automated package check.

https://cran.r-project.org/web/checks/check_results_codebookr.html

Specifically, there was 1 warning and 1 note:

  • S3 generic warning
  • CURL note

S3 generic warning

checking S3 generic/method consistency ... WARNING
cb_summary_stats_to_ft:
  function(df, ...)
cb_summary_stats_to_ft.summary_many_cats:
  function(df, col_width)

cb_summary_stats_to_ft:
  function(df, ...)
cb_summary_stats_to_ft.summary_numeric:
  function(df, col_width)

cb_summary_stats_to_ft:
  function(df, ...)
cb_summary_stats_to_ft.summary_time:
  function(df, col_width)

cb_summary_stats_to_ft:
  function(df, ...)
cb_summary_stats_to_ft.summary_few_cats:
  function(df, col_width)
See section ‘Generic functions and methods’ in the ‘Writing R
Extensions’ manual.

I think I fixed this warning by adding ... to each of the methods as discussed here.

CURL note

checking dependencies in R code ... NOTE
Initiating curl with CURL_SSL_BACKEND: openssl

I think I can just ignore this one.

Build check issues

Of course, after fixing the S3 generic warning, other build check issues came up.

Maintainer note

checking CRAN incoming feasibility ... [17s] NOTE
Maintainer: 'Brad Cannell <brad.cannell@gmail.com>'

I'm just adding this note to cran-comments.md and not taking any action.

Long-running example(s)

checking examples ... [16s] NOTE
Examples with CPU (user + system) or elapsed time > 10s
         user system elapsed
codebook 12.1      1   13.78

It looks like the codebook() function example take a long time to run. I need to find a way to shorten it.

In #18, I got feedback from CRAN about a different issue, but it seems applicable here.

\dontrun{} should only be used if the example really cannot be executed
(e.g. because of missing additional software, missing API keys, ...) by
the user. That's why wrapping examples in \dontrun{} adds the comment
("# Not run:") as a warning for the user.
Does not seem necessary.
Please unwrap the examples if they are executable in < 5 sec, or replace
\dontrun{} with \donttest{}.

So, it seems like I should be able to wrap the codebook() example code with \dontrun{} and that should be permissible because it is not executable in < 5 secs. Add that last part to cran-comments.md.

flextable dependency error

I'm not sure why this is coming up. I've never had it before and I didn't make any changes to the flextable code.

* checking package dependencies ... ERROR
Package required but not available: 'flextable'

See section 'The DESCRIPTION file' in the 'Writing R Extensions'
manual.

It looks like this could be a problem with the Windows server that is being used for testing. Not my package. I'm going to try submitting to CRAN without doing anything and see what happens.

Tasks

  • Fix S3 generic warning
  • Fix codebook() example time to run
  • View results of win builder
  • Merge into main branch
  • Submit to CRAN
  • Fix flextable dependency error
@mbcann01 mbcann01 self-assigned this Mar 16, 2023
@mbcann01 mbcann01 added the bug Something isn't working label Mar 16, 2023
mbcann01 added a commit that referenced this issue Mar 16, 2023
mbcann01 added a commit that referenced this issue Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant