You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm just adding this note to cran-comments.md and not taking any action.
Long-running example(s)
checking examples ... [16s] NOTE
Examples with CPU (user + system) or elapsed time > 10s
user system elapsed
codebook 12.1 1 13.78
It looks like the codebook() function example take a long time to run. I need to find a way to shorten it.
In #18, I got feedback from CRAN about a different issue, but it seems applicable here.
\dontrun{} should only be used if the example really cannot be executed
(e.g. because of missing additional software, missing API keys, ...) by
the user. That's why wrapping examples in \dontrun{} adds the comment
("# Not run:") as a warning for the user.
Does not seem necessary.
Please unwrap the examples if they are executable in < 5 sec, or replace
\dontrun{} with \donttest{}.
So, it seems like I should be able to wrap the codebook() example code with \dontrun{} and that should be permissible because it is not executable in < 5 secs. Add that last part to cran-comments.md.
flextable dependency error
I'm not sure why this is coming up. I've never had it before and I didn't make any changes to the flextable code.
* checking package dependencies ... ERROR
Package required but not available: 'flextable'
See section 'The DESCRIPTION file' in the 'Writing R Extensions'
manual.
It looks like this could be a problem with the Windows server that is being used for testing. Not my package. I'm going to try submitting to CRAN without doing anything and see what happens.
Tasks
Fix S3 generic warning
Fix codebook() example time to run
View results of win builder
Merge into main branch
Submit to CRAN
Fix flextable dependency error
The text was updated successfully, but these errors were encountered:
Overview
On 2023-03-08 I received an email from Kurt Hornik (CRAN) letting me know that
codebookr
was no longer passing an automated package check.https://cran.r-project.org/web/checks/check_results_codebookr.html
Specifically, there was 1 warning and 1 note:
S3 generic warning
I think I fixed this warning by adding
...
to each of the methods as discussed here.CURL note
I think I can just ignore this one.
Build check issues
Of course, after fixing the S3 generic warning, other build check issues came up.
Maintainer note
I'm just adding this note to
cran-comments.md
and not taking any action.Long-running example(s)
It looks like the
codebook()
function example take a long time to run. I need to find a way to shorten it.In #18, I got feedback from CRAN about a different issue, but it seems applicable here.
So, it seems like I should be able to wrap the
codebook()
example code with\dontrun{}
and that should be permissible because it is not executable in < 5 secs. Add that last part tocran-comments.md
.flextable dependency error
I'm not sure why this is coming up. I've never had it before and I didn't make any changes to the
flextable
code.It looks like this could be a problem with the Windows server that is being used for testing. Not my package. I'm going to try submitting to CRAN without doing anything and see what happens.
Tasks
codebook()
example time to runflextable
dependency errorThe text was updated successfully, but these errors were encountered: