feat: position arguments can be proxied through a task now

brad-jones · Jun 26, 2020 · d535162 · d535162
1 parent f6c0da5
commit d535162
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/lib/src/build_arg_parser.dart b/lib/src/build_arg_parser.dart
@@ -44,6 +44,11 @@ ArgParser buildArgParser(
     for (var parameter in e.value.parameters) {
       var optName = MirrorSystem.getName(parameter.simpleName).paramCase;
 
+      if (optName == 'argv' &&
+          parameter.type.reflectedType.toString() == 'List<String>') {
+        continue;
+      }
+
       var abbrValue = Abbr.hasMetadata(parameter)
           ? Abbr.fromMetadata(parameter).value
           : null;

diff --git a/lib/src/executor.dart b/lib/src/executor.dart
@@ -68,8 +68,14 @@ Future<void> executor(
   }
 
   var taskParameterValues = task.parameters.map((p) {
+    dynamic v;
+
     var pName = MirrorSystem.getName(p.simpleName).paramCase;
-    var v = parsedArgv.command[pName];
+    if (pName == 'argv' && p.type.reflectedType.toString() == 'List<String>') {
+      v = parsedArgv.command.rest;
+    } else {
+      v = parsedArgv.command[pName];
+    }
 
     if (v != null) {
       return typeParser(p.type.reflectedType, v);

diff --git a/lib/src/parse_docblocks.dart b/lib/src/parse_docblocks.dart
@@ -46,6 +46,10 @@ Future<List<DocBlock>> parseDocBlocks(
     var parameters = <String, String>{};
     for (var parameter in e.value.parameters) {
       var paramName = MirrorSystem.getName(parameter.simpleName);
+      if (paramName == 'argv' &&
+          parameter.type.reflectedType.toString() == 'List<String>') {
+        continue;
+      }
       parameters[paramName] = docBlock
           .skipWhile((_) => !_.startsWith('* [$paramName]'))
           .takeWhile(