-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the "update guzzle" branch #28
Fixed the "update guzzle" branch #28
Conversation
…g Next Significant Release, etc.
Should be OK now... |
Update guzzle
…tional properties in JsonVisitor)
…tional properties in JsonVisitor)
Changes Unknown when pulling 6e41ceb on David-Guillot:update-guzzle into * on bradfeehan:update-guzzle*. |
Changes Unknown when pulling 6e41ceb on David-Guillot:update-guzzle into * on bradfeehan:update-guzzle*. |
Here... Updated Guzzle to 3.7.4 and simplified some stuff with the EmbeddedCommand ;) |
Hello! Thank you so much for your work. I'd love to merge this pull request. There's a couple of (minor) issues at the moment though. I'd love it if you could fix these up and ping me again! I'll comment on the individual lines with more detail. Thanks again! |
|
||
# IDEs | ||
/.idea | ||
/nbproject/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set up a global Git ignore list, where you can ignore temporary files created by your editor or IDE. This saves you adding them to every project you work on. It also saves you having to update them if you decide to try out a new editor! If you don't want to do this for whatever reason (if you use different editors for different languages?), you can at least make these repository-specific, but still avoid sharing them with other contributors to the project.
That's it! The rest looks great. Thanks again for your work, and please let me know how you go. |
Thanks again for this contribution, however I've gone through the process to understand the incompatibilities in detail myself. I've fixed them on a different branch, so this won't be needed. However it was useful as a reference for some of the issues I needed to fix. Thanks! |
Hi,
I just fixed your pending PR :
Now your PR will be able to be merged into master ;)