Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TemplateColumn RemovedInDjango110Warning #346

Closed
prydie opened this issue Jun 21, 2016 · 2 comments · Fixed by mozilla/addons-server#4430 or drummonds/bene#50 · May be fixed by pilnujemy/pytamy#67
Closed

TemplateColumn RemovedInDjango110Warning #346

prydie opened this issue Jun 21, 2016 · 2 comments · Fixed by mozilla/addons-server#4430 or drummonds/bene#50 · May be fixed by pilnujemy/pytamy#67

Comments

@prydie
Copy link

prydie commented Jun 21, 2016

TemplateColumn uses Context rather than a dict to render the template which will be removed in Django 1.10 giving the below warning.

WARNING 2016-06-21 15:02:43,888 py.warnings 15308 139672357193472 /usr/local/django/virtualenvs/<redacted>/local/lib/python2.7/site-packages/django_tables2/columns/templatecolumn.py:70: RemovedInDjango110Warning: render() must be called with a dict, not a RequestContext.
  return template.render(context)
@jieter
Copy link
Owner

jieter commented Jun 21, 2016

I see, that should be fixed. A bit strange this warning is not raised when running the tests against 1.10 in CI

Are you willing to fix that and open a pull request?

@prydie
Copy link
Author

prydie commented Jun 21, 2016

@jieter I'm a little stretched at the moment so until we're actually looking to move to 1.10 this is merely an irritation in the logs that I thought I'd bring to your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment