Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-github to v50 #86

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

asvoboda
Copy link
Contributor

No description provided.

@asvoboda
Copy link
Contributor Author

hey @wlynch do you mind taking a look when you get a chance?

@wlynch
Copy link
Collaborator

wlynch commented Jan 30, 2023

Sure thing! I'll also get dependabot set up so we can automate these types of PRs 🙂

@wlynch wlynch merged commit 97b6ed0 into bradleyfalzon:master Jan 30, 2023
@wlynch
Copy link
Collaborator

wlynch commented Jan 30, 2023

We already have dependabot set up - it just doesn't know how to handle this library since it's a "major version" bump 🙁

@asvoboda
Copy link
Contributor Author

Yeah go-github is a bit difficult with the number of major version updates. I've toyed around with https://github.com/marwan-at-work/mod, but it wouldn't handle the actual code breaks that could happen.

@dnwe
Copy link

dnwe commented Feb 6, 2023

Aside: renovatebot/renovate will attempt to do major upgrades using marwan-at-work/mod for you — yes it wouldn't help fix API changes, but it'll raise the PR and you can have it automerge if status checks (compile+test) pass

@wlynch please could you tag a new release version so we can pull in the various dependency upgrades since 2.1.0?

@asvoboda asvoboda deleted the as/update-go-github-v50 branch February 28, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants