Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per user and per repo configurations #8

Open
bradleyfalzon opened this issue Nov 5, 2016 · 0 comments
Open

Support per user and per repo configurations #8

bradleyfalzon opened this issue Nov 5, 2016 · 0 comments

Comments

@bradleyfalzon
Copy link
Owner

bradleyfalzon commented Nov 5, 2016

As a user, I should be able to configure which checks run across all my repositories as well as support a per repository configuration (perhaps via .gopherci.yml - so anyone with write access to the repo, or sending a PR could correctly configure the installation).

I may also want to ignore failures that occur within the vendor folder, but this may be a global setting for the installation.

Relates to #3.

bradleyfalzon added a commit that referenced this issue May 17, 2017
Users should be able to apply per repository configuration for GopherCI via
a config file in the repository, this allows non-admin users to modify
GopherCI on a per repository basis if they have write access. Which practically
means users can also have their pull request modify GopherCI if they require
additional packages to be installed (for cgo for example) or if they want to
modify the tools being run.

We achieve this by including a YAMLConfig which implements a configReader
interface, an interface was chosen primarily to keep tests simpler, but
the analyser doesn't really care where the config came from, just that it's
able to receive one.

The YAMLConfig should be preloaded with the global settings and then it should
filter the config based on reading the repository's config file, and finally
returning the config to analyser to use.

Relates #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant