Make SnapshotT() a no-op for failed tests #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgoodall01
changed the title
bradleyjkemp
requested changes
May 18, 2018
cupaloy.go
Outdated
| err := c.snapshot(snapshotName, i...) | ||
| if err != nil { | ||
| t.Error(err) | ||
| if !t.Failed() { |
There was a problem hiding this comment.
Can this be refactored to keep normal code at minimal indentation? See https://github.com/golang/go/wiki/CodeReviewComments#indent-error-flow
There was a problem hiding this comment.
So just
if t.Failed() {
return
}
...
...| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| defaultConfig().SnapshotT(t, i...) |
|
Alright, just implemented your changes. |
cupaloy.go
Outdated
| @@ -66,6 +62,9 @@ func (c *config) SnapshotMulti(snapshotID string, i ...interface{}) error { | |||
|
|
|||
| func (c *config) SnapshotT(t *testing.T, i ...interface{}) { | |||
| t.Helper() | |||
| if !t.Failed() { | |||
There was a problem hiding this comment.
This should just be if t.Failed() surely?
Unfortunately testing.T cannot be mocked so I'm unable to test these methods in CI yet
bradleyjkemp
approved these changes
May 18, 2018
|
Fixes #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips a
cupaloy.SnapshotT()invocation when the test has already failed. This avoids saving test snapshots containing known-bad data on a test's first invocation.cc #31