Allow some helper methods to be used in Jasminerice #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Having jasminerice dynamically load Jasminerice::HelperMethods
bradphelan
added a commit
that referenced
this pull request
Feb 13, 2012
Allow some helper methods to be used in Jasminerice
|
I don't think it is a proper use of begin/rescue unless it's really unexpected that I have no Jasminerice::HelperMethods. |
bradphelan
added a commit
that referenced
this pull request
May 27, 2012
Fix PR #32. Currently if you have no helpers it just pollutes logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way that you can use helper methods in jasminerice fixture.
The reason behind it is I want to reuse some views from the application (to avoid duplicate) which in turn rely on some helpers methods of devise
This pull request is very simple. I try to include Jasminerice::HelperMethods (which should be placed inside lib/) into SpecController. Incase Jasminerice::HelperMethods is not found, it just fall back to default (without any helpers)