Addressing issues after email #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cleaned up the rest of the client code to be more hook friendly with no linter warnings now for all the useEffect hooks. |
bushblade
commented
Feb 3, 2020
| instagram: loading || !profile.social ? '' : profile.social.instagram | ||
| }); | ||
| }, [loading, getCurrentProfile]); | ||
| if (!profile) getCurrentProfile(); |
There was a problem hiding this comment.
Simpler useEffect that follows the linter suggestions.
bushblade
commented
Feb 3, 2020
| @@ -4,48 +4,41 @@ import PropTypes from 'prop-types'; | |||
| import { connect } from 'react-redux'; | |||
| import { createProfile, getCurrentProfile } from '../../actions/profile'; | |||
|
|
|||
| const initialState = { | |||
There was a problem hiding this comment.
initial state outside of component to avoid triggering a re-render in useEffect.
bushblade
added a commit
to bushblade/devconnector_2.0
that referenced
this pull request
Feb 6, 2020
Merge pull request bradtraversy#72 from bushblade/master
NinjaDev0107
added a commit
to NinjaDev0107/devconnector_2.0
that referenced
this pull request
Nov 20, 2023
Addressing issues after email
NinjaDev0107
added a commit
to NinjaDev0107/devconnector_2.0
that referenced
this pull request
Nov 20, 2023
Merge pull request bradtraversy#72 from bushblade/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from a minor syntax error in routes/auth/profile.js and some unused and missing cases for auth reducer as far as I can see the app is running fine after fixing these issues.
I can login a user and get redirected, I can logout and get redirected.
I have contacted the individual who raised the issues in the course for more details and will follow up with him and update further if needed.
Should also fix issue #70