Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint Calculation and Classes Being Removed #284

Closed
cpoteet opened this issue Oct 9, 2014 · 3 comments
Closed

Breakpoint Calculation and Classes Being Removed #284

cpoteet opened this issue Oct 9, 2014 · 3 comments

Comments

@cpoteet
Copy link

cpoteet commented Oct 9, 2014

Two things:

  1. The value for the breakpoints absolutely should be based on viewport by default. I wasted far too much time trying to figure out what was going on. All other media queries operate that way (at this point in time), and I suggest you go that route and allow someone to override with a element width.

  2. I noticed classes would get dropped between custom breakpoints for some reason. I had my custom breakpoints:

   breakpoints: {
         small: 480,
         medium: 740
   },

But for some reason between the two, medium would drop and "phone" would come back. Then small would finally trigger. It was frustrating.

@cpoteet
Copy link
Author

cpoteet commented Oct 9, 2014

At the very least you should note how the breakpoint calculation happens in your documentation.

@tkent
Copy link

tkent commented Oct 21, 2014

Just ran into the same confusion and was going to file an issue when I found this. It certainly seems like the wrong behavior.

@bradvin
Copy link
Member

bradvin commented Oct 21, 2014

This is being addressed in V3 of FooTable - it was a bad design choice to change to the table width over the viewport width. V3 will have the default based on viewport width and an option to change it to table width. We are hoping to commit a V3 branch to the repo in the next 2 weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants