Fixed error with VS 2017 build #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LI still works with "build.bat"
| @@ -5,6 +5,10 @@ | |||
| <PropertyGroup> | |||
| <PackageTargetFallback>$(PackageTargetFallback);portable-net45+win8+wp8+wpa81;</PackageTargetFallback> | |||
| <RunPostBuildEvent>OnBuildSuccess</RunPostBuildEvent> | |||
| <PreBuildEvent>cd $(SolutionDir) | |||
| call pre-build.bat</PreBuildEvent> | |||
There was a problem hiding this comment.
@BenjaminAbt will this work on a mac? you've got a *.bat file extension in there.
|
This looks like it makes an OS assumption with the *.bat files. @BenjaminAbt please remember one of the goals is to keep this multi-platform. |
|
You originally added build.bat ;-) I've just edited it. |
|
@BenjaminAbt yes i know i added one but it was due to the issues the vs17 issue is causing and it was a last-ditch strategy. we have two grunt tasks - one for prebuild and one for after. they're not getting called properly by the dotnet build process after the introduction of the *.csproj. |
|
Ok, good to know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to use downr with VS2017 because the pre-build task were ignored.
Added two script files to fixed this behavior. Now build of VS2017 works the same way like CLI before.