Skip to content

Commit

Permalink
deps: deck config snippet implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
Travis Clarke committed Sep 17, 2019
1 parent 6699060 commit 6c573ac
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 6 deletions.
1 change: 1 addition & 0 deletions go.mod
Expand Up @@ -19,6 +19,7 @@ require (
github.com/bazelbuild/buildtools v0.0.0-20190404153937-93253d6efaa9
github.com/beorn7/perks v1.0.1 // indirect
github.com/bwmarrin/snowflake v0.0.0
github.com/clarketm/json v1.13.0
github.com/client9/misspell v0.3.4
github.com/denisenkom/go-mssqldb v0.0.0-20190111225525-2fea367d496d // indirect
github.com/djherbis/atime v1.0.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Expand Up @@ -53,6 +53,8 @@ github.com/blang/semver v3.5.1+incompatible h1:cQNTCjp13qL8KC3Nbxr/y2Bqb63oX6wdn
github.com/blang/semver v3.5.1+incompatible/go.mod h1:kRBLl5iJ+tD4TcOOxsy/0fnwebNt5EWlYSAyrTnjyyk=
github.com/bwmarrin/snowflake v0.0.0 h1:dRbqXFjM10uA3wdrVZ8Kh19uhciRMOroUYJ7qAqDLhY=
github.com/bwmarrin/snowflake v0.0.0/go.mod h1:NdZxfVWX+oR6y2K0o6qAYv6gIOP9rjG0/E9WsDpxqwE=
github.com/clarketm/json v1.13.0 h1:gvWCzx4JHbBeVPpSV9LVr+PXfRInRnDy80D9nnTLULs=
github.com/clarketm/json v1.13.0/go.mod h1:ynr2LRfb0fQU34l07csRNBTcivjySLLiY1YzQqKVfdo=
github.com/client9/misspell v0.3.4 h1:ta993UF76GwbvJcIo3Y68y/M3WxlpEHPWIGDkJYwzJI=
github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
github.com/coreos/etcd v3.3.10+incompatible/go.mod h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE=
Expand Down
5 changes: 4 additions & 1 deletion pkg/genyaml/BUILD.bazel
Expand Up @@ -6,7 +6,10 @@ go_library(
data = ["//prow/plugins:config-src"],
importpath = "k8s.io/test-infra/pkg/genyaml",
visibility = ["//visibility:public"],
deps = ["@in_gopkg_yaml_v3//:go_default_library"],
deps = [
"@com_github_clarketm_json//:go_default_library",
"@in_gopkg_yaml_v3//:go_default_library",
],
)

go_test(
Expand Down
4 changes: 4 additions & 0 deletions pkg/genyaml/OWNERS
@@ -0,0 +1,4 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- clarketm
5 changes: 3 additions & 2 deletions pkg/genyaml/genyaml.go
Expand Up @@ -61,18 +61,19 @@ package genyaml

import (
"bytes"
"encoding/json"
"errors"
"fmt"
"go/ast"
"go/doc"
"go/parser"
"go/token"
yaml3 "gopkg.in/yaml.v3"
"reflect"
"regexp"
"strings"
"sync"

"github.com/clarketm/json"
yaml3 "gopkg.in/yaml.v3"
)

const (
Expand Down
6 changes: 3 additions & 3 deletions prow/plugins/approve/approve.go
Expand Up @@ -134,9 +134,9 @@ func helpProvider(config *plugins.Configuration, enabledRepos []string) (*plugin
"ORGANIZATION/REPOSITORY",
},
DeprecatedImplicitSelfApprove: new(bool),
RequireSelfApproval: new(bool),
DeprecatedReviewActsAsApprove: new(bool),
IgnoreReviewState: new(bool),
RequireSelfApproval: new(bool),
DeprecatedReviewActsAsApprove: new(bool),
IgnoreReviewState: new(bool),
},
},
})
Expand Down
8 changes: 8 additions & 0 deletions repos.bzl
Expand Up @@ -1903,6 +1903,14 @@ def go_repositories():
sum = "h1:bWDMxwH3px2JBh6AyO7hdCn/PkvCZXii8TGj7sbtEbQ=",
version = "v0.0.0-20180111231733-ee0de3bc6815",
)
go_repository(
name = "com_github_clarketm_json",
build_file_generation = "on",
build_file_proto_mode = "disable",
importpath = "github.com/clarketm/json",
sum = "h1:gvWCzx4JHbBeVPpSV9LVr+PXfRInRnDy80D9nnTLULs=",
version = "v1.13.0",
)
go_repository(
name = "com_github_golang_lint",
build_file_generation = "on",
Expand Down

0 comments on commit 6c573ac

Please sign in to comment.