Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow type Integration, and static typing across the files. #98

Merged
merged 2 commits into from Sep 26, 2020
Merged

Conversation

s-yadav
Copy link
Collaborator

@s-yadav s-yadav commented Sep 19, 2020

No description provided.

@ameerthehacker
Copy link
Member

There are few any types here and there, can we change them to unknown if possible?

- Fixed some possible bugs identified by flow type.
- Remove unused old files
@s-yadav
Copy link
Collaborator Author

s-yadav commented Sep 20, 2020

Do you mean mixed type?

Some of them are intentionally annotated as any, and I do typecast it on places where it is used. The problem is flow can't figure runtime logic, and mixed type requires handling all the types.

@ameerthehacker
Copy link
Member

sorry my bad went into typescript world for a minute

@s-yadav
Copy link
Collaborator Author

s-yadav commented Sep 20, 2020

I guess the unknown type (typescript) is equivalent to mixed type(flowtype).

On taking another glance some of them can indeed be converted on mixed type. Mostly on the Children API. I will check it and update it.

@ameerthehacker
Copy link
Member

Cool nice

@s-yadav s-yadav merged commit 015fc87 into master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants