Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract reconnect-notice as module #144

Closed
braid-sync opened this issue Jun 28, 2018 · 1 comment
Closed

extract reconnect-notice as module #144

braid-sync opened this issue Jun 28, 2018 · 1 comment

Comments

@braid-sync
Copy link

braid-sync commented Jun 28, 2018

A task for new Braid contributors.

We're extracting parts out of "Braid core" into loosely-coupled modules, to ease future development. As part of this effort, the functionality of the "reconnect-notice" can be extracted.
Currently, when the websocket is disconnected, a red notice bar is shown (you can trigger this by starting Braid in dev, then, in your repl, doing (stop!)).

Extract this functionality out of core and into a new module.

Notes:

  • braid.core.client.ui.views.reconnect-overlay is where the view is now
  • refer to braid.stars for how to write a module
  • you should make use of braid.core.api/register-root-view!
@braid-sync braid-sync changed the title Extract reconnect-notice as module extract reconnect-notice as module Sep 1, 2018
jamesnvc added a commit to PiotrKurnik/braid that referenced this issue Jan 14, 2019
jamesnvc added a commit that referenced this issue Jan 14, 2019
…dule

disconnect noticed converted into a module
@jamesnvc
Copy link
Contributor

Completed by 2004f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants