Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor gateway form handlers and subscriptions #367

Open
rafd opened this issue May 29, 2017 · 0 comments
Open

refactor gateway form handlers and subscriptions #367

rafd opened this issue May 29, 2017 · 0 comments
Labels

Comments

@rafd
Copy link
Member

rafd commented May 29, 2017

Re: braidchat/braid#87 (review)

I recognize that the way these handlers / subscriptions are implemented is different than the rest of the app, where handlers and subscriptions are directly defined once. Re-frame currently makes it challenging to "modularize" or subset parts of the front-end.

Some alternatives...

  • we could have the handlers be under one name, and take they key as an extra parameter, but then the views would have to know that key, which is exactly the sort of implementation detail that handlers / subscriptions are supposed to separate out.

  • abandon re-frame for these modules and just make all the data local to a form component

  • keep as is, and refactor when re-frame modularization hits

  • ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant