-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use known option #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are three changes in this request:
- docs
- help margins
- practice options changed
The last I do not support for reasons described above (also: I plan to probably add more decks, e. g. english, spanish, french, deutsh, math, musical, chemical...; I plan to probably add a writing mode, where letters are mirrored, add an option to switch on/off higher probability of occurence of letters that user typed in incorrectly; this all seems to be more logical to control within a single screen, which is accessible in one click and icon is BIG and MEANINGFUL (who knows what's behind "other options"?)).
Let's raise a discussion? @braille-systems/learn-braille-team
helpItems.forEach { helpItem -> | ||
val textView = TextView(context).apply { | ||
setPaddingRelative(2, 0, 2, 0) | ||
setPaddingRelative(30, 0, 20, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR solves a particular problem. Not going to redesign something general here. |
It solves a problem in a strange fashion. |
there are basically two types of features:
|
here is my vision (though not fully functional, but design is ~ as I would like to see) |
I prefer the way @winter-yuki implemented it tbh. Its easily accessed from where its needed the most - right from the practice with one click. |
@kaustika thank you. But in my version these settings are accessible in one click, too. This menu pops up on “change decks” button click |
I trust in good judgement and common sense of @kaustika and @winter-yuki so let's for now it be like this. @winter-yuki what do you think about keeping the switch in general settings? I suppose it's a good idea, maybe you could do it? |
@winter-yuki please, return the switch (or decide not to return) and let me know when you're done, I will change the help message accordingly and merge this request. |
I will delete the corresponding branch. But will save this code in my clone of this repo: https://github.com/zuevval/learn-braille/tree/feature/use-known-option Just in case. |
Closes #203