Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add progress bar to assembly download #91

Merged
merged 1 commit into from
Sep 14, 2018
Merged

add progress bar to assembly download #91

merged 1 commit into from
Sep 14, 2018

Conversation

mschrimpf
Copy link
Member

also get rid of unused parameter credentials

@mschrimpf
add progress bar to assembly download
ae983ca 
also get rid of unused parameter credentials
@mschrimpf mschrimpf merged commit 26000c7 into brain-score:master Sep 14, 2018
@mschrimpf mschrimpf deleted the s3-progress-bar branch September 14, 2018 18:31
jjpr-mit
jjpr-mit reviewed Sep 14, 2018
View reviewed changes
Copy link
Contributor

@jjpr-mit jjpr-mit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. How does the progress bar look?

@mschrimpf
Copy link
Member Author

there's an example of it here: https://pypi.org/project/tqdm/

@mschrimpf mschrimpf mentioned this pull request Sep 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjpr-mit jjpr-mit jjpr-mit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mschrimpf @jjpr-mit