Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morning Session: Peer to Peer Code Review #4

Open
2 tasks
jmoseka opened this issue May 10, 2022 · 2 comments
Open
2 tasks

Morning Session: Peer to Peer Code Review #4

jmoseka opened this issue May 10, 2022 · 2 comments

Comments

@jmoseka
Copy link

jmoseka commented May 10, 2022

Hi @braincee @yayner2002
Wonderful work on your project.

✅Easy to follow code
✅Working solution

However, there are a few suggestions we noted that you can consider implementing them on the project.

  • Consider putting all test files under one directory so that it is easy to locate and files stay organized.
  • We think it would be better to create a mock-up storage that mimics the window local storage functionality to test the file.

Otherwise, there's not much to add other than keep it up! 👍
Team: @jmoseka @SoniaKarungi @Baroka-wp
@braincee
Copy link
Owner

@jmoseka thanks very much

download

@yayner2002
Copy link
Collaborator

yayner2002 commented Nov 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmoseka @braincee @yayner2002