Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make usage of 'choice_translation_domain' option #382

Merged
merged 1 commit into from
Dec 20, 2015

Conversation

Restless-ET
Copy link
Contributor

Make usage of choice_translation_domain option at choice_widget_options block in a BC way.

I believe this fixes the translation handling for 2.7 referred at #377.

Make usage of 'choice_translation_domain' option at 'choice_widget_options' block in a BC way.
@Restless-ET
Copy link
Contributor Author

@florianeckerstorfer Did you have a chance to look into this?

It's basically the same as #378 but in way that should support SF < 2.7 as well.

@DerekRoth
Copy link

+1
Using this bundle, a lot of "missing messages" appear in the dev toolbar even when using false as choice_translation_domain. So i'm unable to see if i really have missing translations or false positives only.

florianeckerstorfer pushed a commit that referenced this pull request Dec 20, 2015
Use 'choice_translation_domain' option
@florianeckerstorfer florianeckerstorfer merged commit e322b94 into braincrafted:develop Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants