Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for output shape and gradients visualization + bugfix #167

Merged
merged 6 commits into from
Nov 10, 2020

Conversation

robintibor
Copy link
Contributor

No description provided.

@robintibor robintibor changed the title Tests for output shape and gradients Tests for output shape and gradients visualization Sep 18, 2020
@robintibor robintibor changed the title Tests for output shape and gradients visualization Tests for output shape and gradients visualization + bugfix Sep 18, 2020
@robintibor
Copy link
Contributor Author

and even found a bug! @agramfort must be so happy :)
Before, amplitude gradients were accidentally summed over filters, so gradient for filter 3 would be sum of grads filter 0,1,2,3 instead of being just gradient of filter 3 as intended.

@agramfort
Copy link
Collaborator

I am happy but I would be even happier if you could update changelog to document the bug fix :)

@robintibor
Copy link
Contributor Author

Now I am sure you are so happy you want to invite me me for a Pizza Pesto from https://www.la-guichetta.fr/notre-carte/pizzas-au-feu-de-bois/ , correct? :)

@agramfort
Copy link
Collaborator

I won't pay the full pizza yet :)

what I have in mind is something like: https://mne.tools/stable/whats_new.html
or https://scikit-learn.org/stable/whats_new/v0.23.html

so it appears on the website so contributors get public credit for their efforts!

@robintibor
Copy link
Contributor Author

hmhm ok for now I will merge this so there is at least anything. then go further in separate pr

@robintibor robintibor merged commit 683aeda into braindecode:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants