Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing and loading of windows datasets #132

Merged
merged 6 commits into from Jul 3, 2020

Conversation

gemeinl
Copy link
Collaborator

@gemeinl gemeinl commented Jul 2, 2020

No description provided.

@gemeinl gemeinl requested a review from robintibor July 2, 2020 16:15
@agramfort
Copy link
Collaborator

@gemeinl can you add tests?

windows_dataset.description.to_json(os.path.join(path, "description.json"))


def recover_windows_dataset(path, ids_to_load=None):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the more common naming are

load_ / read_
save_ / write_

cf numpy, mne etc.

@robintibor
Copy link
Contributor

amazing great

@robintibor robintibor merged commit 987eb23 into braindecode:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants