-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New EEG-Inception architecture for motor imagery #428
New EEG-Inception architecture for motor imagery #428
Conversation
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 84.28% 84.81% +0.53%
==========================================
Files 46 48 +2
Lines 3601 3728 +127
==========================================
+ Hits 3035 3162 +127
Misses 566 566 |
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
Let me know if this is what you had in mind @agramfort |
@bruAristimunha @sliwy feel free to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cedricrommel great stuff! To me it's ready to merge :)
Great thanks! I'll merge it then! |
I realized that the there are two papers proposing models called EEGInception in the recent literature: one for ERP classification (which is already implemented in braindecode) and another for motor imagery. This PR renames the existing EEG-Inception model for ERP to raise the ambiguity and implements the other architecture for motor-imagery tasks.