New EEG-Inception architecture for motor imagery - #428
Merged
bruAristimunha merged 13 commits intoNov 9, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 84.28% 84.81% +0.53%
==========================================
Files 46 48 +2
Lines 3601 3728 +127
==========================================
+ Hits 3035 3162 +127
Misses 566 566 |
agramfort
reviewed
Nov 8, 2022
agramfort
reviewed
Nov 8, 2022
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
Collaborator
Author
|
Let me know if this is what you had in mind @agramfort |
agramfort
reviewed
Nov 8, 2022
agramfort
approved these changes
Nov 8, 2022
Collaborator
|
@bruAristimunha @sliwy feel free to merge |
sliwy
reviewed
Nov 8, 2022
sliwy
approved these changes
Nov 9, 2022
sliwy
left a comment
sliwy
left a comment
Collaborator
There was a problem hiding this comment.
@cedricrommel great stuff! To me it's ready to merge :)
Collaborator
Author
|
Great thanks! I'll merge it then! |
bruAristimunha
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that the there are two papers proposing models called EEGInception in the recent literature: one for ERP classification (which is already implemented in braindecode) and another for motor imagery. This PR renames the existing EEG-Inception model for ERP to raise the ambiguity and implements the other architecture for motor-imagery tasks.