Adding SleepPhysionetChallenge2018 dataset - #621
Conversation
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 87.55% 86.07% -1.48%
==========================================
Files 68 69 +1
Lines 6180 6321 +141
==========================================
+ Hits 5411 5441 +30
- Misses 769 880 +111 |
|
Do we really need to add these large csv etc files directly into the codebase? Is there not any other way, like are they hosted somewhere and downloadable? Or is this a common practise to do this way? Seems a bit unexpected to me? |
|
Indeed, I don't think it's a good idea to add this big file here. But, it seems like this is what MNE does in the other sleep dataset. Any idea how to solve this point, @agramfort and @hubertjb? |
|
@gustavohenriquesr,Just to check, you had to do something to make this dataset fully work? |
|
Hi @bruAristimunha, In fact, curiously I had trouble creating the windows for the dataset (the labels weren't being assigned), but when I used a local copy of the sleep_physio_challe_18.py file, it worked correctly. I didn't get to explore the code further in this regard. I'll check again and if I find anything, I'll let you know. I suggest doing a local test, if you haven't already. |
|
@gustavohenriquesr, It was super silly, test set has no associated label! |
Most of code was from https://github.com/hubertjb/dynamic-spatial-filtering