Adding SleepPhysionetChallenge2018 dataset #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 87.29% 86.77% -0.53%
==========================================
Files 67 68 +1
Lines 6055 6176 +121
==========================================
+ Hits 5286 5359 +73
- Misses 769 817 +48 |
bruAristimunha
commented
May 23, 2024
| # Authors: Hubert Banville <hubert.jbanville@gmail.com> | ||
| # | ||
| # License: BSD (3-clause) | ||
| # Code remove from the repository |
There was a problem hiding this comment.
Suggested change
| # Code remove from the repository | |
| # Code copied from the repository |
Comment on lines
+28
to
+33
| PC18_DIR = op.join(op.dirname(__file__), "data", "pc18") | ||
| PC18_RECORDS = op.join(PC18_DIR, "sleep_records.csv") | ||
| PC18_INFO = op.join(PC18_DIR, "age-sex.csv") | ||
| PC18_URL = "https://physionet.org/files/challenge-2018/1.0.0/" | ||
| PC18_SHA1_TRAINING = op.join(PC18_DIR, "training_SHA1SUMS") | ||
| PC18_SHA1_TEST = op.join(PC18_DIR, "test_SHA1SUMS") |
There was a problem hiding this comment.
I am wondering if their is a better way to do this
|
Do we really need to add these large csv etc files directly into the codebase? Is there not any other way, like are they hosted somewhere and downloadable? Or is this a common practise to do this way? Seems a bit unexpected to me? |
|
Indeed, I don't think it's a good idea to add this big file here. But, it seems like this is what MNE does in the other sleep dataset. Any idea how to solve this point, @agramfort and @hubertjb? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of code was from https://github.com/hubertjb/dynamic-spatial-filtering