Skip to content

Adding SleepPhysionetChallenge2018 dataset - #621

Merged
bruAristimunha merged 26 commits into
braindecode:masterfrom
bruAristimunha:pc18-dataset
Sep 25, 2024
Merged

Adding SleepPhysionetChallenge2018 dataset#621
bruAristimunha merged 26 commits into
braindecode:masterfrom
bruAristimunha:pc18-dataset

Conversation

@bruAristimunha

Copy link
Copy Markdown
Collaborator

bruAristimunha and others added 13 commits May 20, 2024 19:00
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
Co-authored-by: Hubert Banville <hubert.jbanville@gmail.com>
@codecov

codecov Bot commented May 21, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 21.27660% with 111 lines in your changes missing coverage. Please review.

Project coverage is 86.07%. Comparing base (2c3574a) to head (1b88942).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   87.55%   86.07%   -1.48%     
==========================================
  Files          68       69       +1     
  Lines        6180     6321     +141     
==========================================
+ Hits         5411     5441      +30     
- Misses        769      880     +111     

Comment thread braindecode/datasets/sleep_physio_challe_18.py Outdated
Comment thread braindecode/datasets/sleep_physio_challe_18.py
@robintibor

Copy link
Copy Markdown
Contributor

Do we really need to add these large csv etc files directly into the codebase? Is there not any other way, like are they hosted somewhere and downloadable? Or is this a common practise to do this way? Seems a bit unexpected to me?

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

Indeed, I don't think it's a good idea to add this big file here. But, it seems like this is what MNE does in the other sleep dataset. Any idea how to solve this point, @agramfort and @hubertjb?

Comment thread braindecode/datasets/sleep_physio_challe_18.py Outdated
Comment thread braindecode/datasets/sleep_physio_challe_18.py Outdated
Comment thread braindecode/datasets/sleep_physio_challe_18.py Outdated
@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

@gustavohenriquesr,Just to check, you had to do something to make this dataset fully work?

@gustavohenriquesr

Copy link
Copy Markdown
Contributor

Hi @bruAristimunha,

In fact, curiously I had trouble creating the windows for the dataset (the labels weren't being assigned), but when I used a local copy of the sleep_physio_challe_18.py file, it worked correctly.

I didn't get to explore the code further in this regard. I'll check again and if I find anything, I'll let you know. I suggest doing a local test, if you haven't already.

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

@gustavohenriquesr, It was super silly, test set has no associated label!

@bruAristimunha
bruAristimunha merged commit 5e08c66 into braindecode:master Sep 25, 2024
@bruAristimunha
bruAristimunha deleted the pc18-dataset branch December 4, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants