Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mentalab devices #542

Merged
merged 7 commits into from Sep 19, 2022
Merged

add support for mentalab devices #542

merged 7 commits into from Sep 19, 2022

Conversation

Andrey1994
Copy link
Member

@Andrey1994 Andrey1994 commented Sep 5, 2022

Signed-off-by: Andrey Parfenov a1994ndrey@gmail.com

Tested on windows, can connect to device and get data.

Todo and issues:

  • can connect to device only when LED is blue and blinking, after some time it gets green and you have to restart the device
  • temperature data looks completely wrong, its a random value between 20 and 120, need to check parsing
  • accel and gyro data, instead expected values like -1..0..1(these units used in brainflow) I get something I dont understand, the same in explorepy, so its not an issue with parsing
  • add docs about explore 4 and 8 channels boards
  • add release notes to website
  • need to test on linux and macos, have no hardware
  • cannot test correctness of eeg parsing(I dont get how to connect these electrodes), dont understand the idea of 5th channel... is it a reference which should be subtracted from other channels? these value does not change for me
  • it seems like fw supports timestamp syncronization, need to implement it or at least use sampling rate to correct timestamps which come from batches of datapoints
  • need to test 8 chan board, have no device

To do later in case of requests:

  • add support for sending commands(at least for sampling rate and maybe on\off)
  • add support for impedance measurement

Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
@Andrey1994 Andrey1994 linked an issue Sep 5, 2022 that may be closed by this pull request
@Andrey1994
Copy link
Member Author

data_env.csv
data_orn.csv
data_eeg.csv

data files from explore.py example attached, still dont understand values there

@Andrey1994
Copy link
Member Author

Update:

its not a parsing issue in brainflow for accelerometer, using explorepy I get the same values:

accelerometer
[ -19.093 -134.627 1011.746]

@Andrey1994
Copy link
Member Author

temperature is also correct, I looked at the wrong column before

Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
@Andrey1994
Copy link
Member Author

fixed linux issue, fixed parsing, added commands for sampling rate and test signal. validated against explorepy using test signal

Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
@Andrey1994 Andrey1994 merged commit 491f0ce into master Sep 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the mentalab2 branch September 19, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mentalab devices
1 participant